Update io util to convert path like object to string #8275
Merged
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushdg
commented
May 18, 2021
ayushdg
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8275 +/- ##
===============================================
Coverage ? 82.84%
===============================================
Files ? 105
Lines ? 17865
Branches ? 0
===============================================
Hits ? 14800
Misses ? 3065
Partials ? 0 Continue to review full report at Codecov.
|
kkraus14
approved these changes
May 18, 2021
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
|
There seem to be errors the decimal orc writer tests unrelated to this pr. Might be a timing issue since the to_orc decimal support merged 4 hours back so it may not have made it to the libcudf build in CI |
|
Rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing dask-cudf s3 test introduced from changes to
fsspec.stringify_pathin their 2021.5.0 release.Problem description:
While reading remote files with dask-cudf the
path_or_objectparam is populated with remote file objects such ass3fs.s3Fileorgcsfs.GCSFile. Updates to thefsspec.stringify_pathutil results in returning the string path for such objects resulting in cudf looking for those file paths locally.Fix:
Fix uses one of the branches from the original
stringify_pathutil that checks if apath likeobject implement thefsspathprotocol and gets the string representation from that.